This page has the object to help: - newcomers to get around with the project and the with the github workflow; - developers to save some time, as they don't have to explain those very same things over and over again;
Signed-off-by: Fabiano Fidêncio fidencio@redhat.com
So, this docs PR is really awesome and we needed a guide like this for a while.
My only question is if you think this page should be a top-level one in the table of contents or part of 'contribute'. I'm fine with both, on one hand, this belongs more to contribute, on the other hand, the way you wrote the toc, the guide is more visible.
So I'll merge the PR either way, just tell me your preference :)
Hmm. I've replied by email to this comment on August 1st and seems the reply never reached pagure :-\
Anyways: "I think it would be better as a top-level one. Sincerely, I do believe that it will be more exposed/easier for newcomers to find as a top-level document. Also, there are a few other things that I'd like to have under "newcomers" section, as tips for debugging and/or pbrezina's repos that would be really handy for newcomers but do not exactly follow the "strict" rules for contributions."
fine, pushed.
btw I also replied by e-mail earlier but didn't see my reply here, I guess the mail reply is broken..
Pull-Request has been closed by jhrozek
IMHO. It might be better to rebase PR and merge it. Then summary of closed PR would looks better https://pagure.io/SSSD/docs/pull-requests?status=0
There is also an option to enable hook in pagure which will close PR as merged if commit message contains "Merges: #num_of_PR" or "Megers: $url_of_pr". There are also other options.
e.g. https://pagure.io/SSSD/sssd/pull-request/3374 https://pagure.io/SSSD/sssd/c/0a86dede
(BTW git hook is not enabled by default in SSSD)
activated
This page has the object to help:
- newcomers to get around with the project and the with the github
workflow;
- developers to save some time, as they don't have to explain those
very same things over and over again;
Signed-off-by: Fabiano Fidêncio fidencio@redhat.com