I only have some nitpicks about typos and such:
diff --git a/design_pages/prompting_configuration.rst b/design_pages/prompting_configuration.rst index 4a48b92..8ca1725 100644 --- a/design_pages/prompting_configuration.rst +++ b/design_pages/prompting_configuration.rst @@ -3,9 +3,9 @@ Make authentication prompting configurable Related ticket(s): ------------------ - https://pagure.io/SSSD/sssd/issue/3264 - https://pagure.io/SSSD/sssd/issue/3856 - https://bugzilla.redhat.com/show_bug.cgi?id=1623624 + - https://pagure.io/SSSD/sssd/issue/3264 + - https://pagure.io/SSSD/sssd/issue/3856 + - https://bugzilla.redhat.com/show_bug.cgi?id=1623624 Problem statement ----------------- @@ -39,7 +39,7 @@ separate prompts is useful from the SSSD point of view. However there are services which cannot handle PAM conversations and ask the user directly to enter the needed credentials. On the PAM level those application can put the user input in both prompts or only in the first one. Instead of adding -heuristics to SSSD to figure out what is meant be which application it would be +heuristics to SSSD to figure out what is meant by which application it would be easier and more reliable to be able to configure the expected behavior for each service individually if needed. @@ -93,7 +93,7 @@ prompting if multiple authentication methods are available. E.g. if a Smartcard with a certificate suitable to authenticate the current user is available SSSD will prompt for a Smartcard PIN even if password authentication would be available for the user as well. To see a password prompt the Smartcard has to -be remove first. But there might be cases where password or two-factor +be removed first. But there might be cases where password or two-factor authentication should be preferred and having to remove the Smartcard might be irritating.
Since I have them done locally, just let me know if you prefer to have additional review of the page from someone else or if I can just squash the changes and push the page.
Hi Jakub,
thanks for reading the page, please push with your changes.
bye, Sumit
done and html pushed as well.
Pull-Request has been closed by jhrozek