#57 containers: push nightly tags to quay.io with expiry annotations
Merged by jcline. Opened by jcline.
nightly-image-tags  into  main

Download 57.patch

This adjusts the tags pushed to quay.io to include nightly tags set to expire when the image reaches EOL.

The tests still need adjustments, but I wanted to open this as a draft since I did some non-trivial refactoring.

rebased onto f2ba4b5b422cc83a40bffd636d1ef400b117b655

2 new commits added

  • containers: push nightly tags to quay.io with expiry annotations
  • containers: refactor manifest creation and publishing

Okay, I've adjusted the tests and this should be good to go, although I don't love the hackiness of it all. I guess we can rip out all the special casing whenever registry.fedoraproject.org gets retired.

Yeah, seems ok to me...

On a quick eyeball review I get the idea and it looks fine. If I get a bit of time I'll try to refresh my memory on what the different bits of this are called and suggest a docstring and maybe some changed variable names.

https://specs.opencontainers.org/image-spec/manifest/ refers to the outer manifest as a "fat manifest" (quotation marks in original!) and the index as the "image index", so we could maybe disambiguate a bit using that terminology? i.e. something like this:

class FatManifest:
    """
    A "fat" OCI container manifest, per
    https://specs.opencontainers.org/image-spec/manifest/ . It contains
    an "image index" pointing to multiple individual image manifests,
    one per arch, so forming a multiple-architecture manifest.
    """

1 new commit added

  • Tweak container manifest name and docblock

Thanks, that's much better than my placeholder docs. I've adjusted things and if you're comfortable with the change I can merge things and roll it out shortly.

now we know the correct name for this, maybe we should call it image_index just for clarity/consistency?

just that one minor note, then I think it's good. thanks a lot for doing this!

1 new commit added

  • Rename FatManifest::archive_index to image_index

Pull-Request has been merged by jcline

Metadata