Not sure this works as is, you likely need to pass this to flask.markdown()

We'll need an alembic migration for this

Not sure this works as is, you likely need to pass this to flask.markdown()

Worked for me, though there might be edge cases it doesn't catch.

This change definitely needs alembic migration.

@zlopez @pingou Now that we're between elections, is this something we can get deployed before the F30 elections process starts?

What's involved in doing the alembic migration? Is it something we can get done before the Beta infra freeze or should it wait until after? I'd like to be able to have this before we do F30 voting.

I can take over from you if you like but I'd like the two pending PRs to be reviewed :(

This would allow us to finish deploying elections on openshift in staging, which would allow us to move to production later and gives us an easier workflow to staging and production from git commit :)

@pingou I don't have the skills to provide the review, but I can be annoying to someone until they do it if you need me to.

I ll take the review :-)

Not all elections must have a badge, so we should make this nullable=True :)

I've added the alembic migration in https://pagure.io/elections/c/db28067794018efe9ee4d65826d942c39ef74aba?branch=alembic_migration
Feel free to pull it into your branch.

However, I see the PR is opened against master, we should close it and re-open it against develop (I'll fix pagure to make it the default branch), it seems elections uses the git-flow model.

If we're changing this, what about changing the field name to url_badge ?

If we're changing this, what about changing the field name to url_badge ?

No objections here. I'll make that change and pull in your migration commit and submit a new PR against the right branch.

@bcotton, would you like me to take over the PR to finish it?

@bcotton, would you like me to take over the PR to finish it?

The pesterer has become the pesteree :-)

It's on my list for today, probably within the next hour or so.

Thank you, no worries about this, I just had a little time and I know you're busy :)