elections

#68 Rework the imports in fedmsgshim
Merged by pingou. Opened by pingou.
fix_fedora_messaging  into  develop

Download 68.patch

Basically, we were importing publish from the fedora-messaging API, but
the method in this module is also named publish which led to conflicts
in function name and the wrong one was called out.
This results in no messages being sent.

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

You know you can do "from fedora_messaging.api import publish as fm_publish" or similar, right?

+1

It's also incredibly easy to write a test to assert messages are published: https://fedora-messaging.readthedocs.io/en/stable/testing.html

You know you can do "from fedora_messaging.api import publish as fm_publish" or similar, right?

Yes I wasn't sure if one way is recommended vs the other so I went with this one, seemed more explicit :)

It's also incredibly easy to write a test to assert messages are published: https://fedora-messaging.readthedocs.io/en/stable/testing.html

I need to get on this clearly, thanks for the link! :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.