We'll likely have to pip install the new dependency in the Dockerfile used otherwise this is likely not going to work when we push it to openshift.

That being said the PR looks good to me.

It may be an idea to give the current elections maintainers access to https://pagure.io/elections-messages/ as well

Checking quickly the schemas, the url field of Candidates is nullable, so https://pagure.io/elections-messages/blob/dev/f/fedora_elections_messages/base.py#_54 likely needs to be adjusted (and the tests as well)

Checking quickly the schemas, the url field of Candidates is nullable, so https://pagure.io/elections-messages/blob/dev/f/fedora_elections_messages/base.py#_54 likely needs to be adjusted (and the tests as well)

Oh good catch, it's not absent, it's None. Fixed the schemas.

We'll likely have to pip install the new dependency in the Dockerfile used otherwise this is likely not going to work when we push it to openshift.

Possibly. That would be in Ansible, right?

It may be an idea to give the current elections maintainers access to https://pagure.io/elections-messages/ as well

Will do.

We'll likely have to pip install the new dependency in the Dockerfile used otherwise this is likely not going to work when we push it to openshift.

Possibly. That would be in Ansible, right?

Actually, we're using s2i here, so it may get things from the requirements.txt
already.

Ok, I reviewed the code, re-run all of the tests and even succesfuly built the project locally with s2i (that should mean there will be no problems when building in openshift)