Issue #83: Antora: ascii apostrophe gets "smartified" in the body, and then escaped in the title.... - docs-fp-o

fedora-docs / docs-fp-o

#83 Antora: ascii apostrophe gets "smartified" in the body, and then escaped in the title....

Closed Aug 26, 2018 Opened Jul 30, 2018 by mattdm.

See

*https://docs.fedoraproject.org/en-US/project/
* https://pagure.io/Fedora-Council/council-docs/blob/master/f/project/modules/ROOT/pages/index.adoc

The source page includes

Fedora's Mission and Foundations

This is rendered in HTML as

<h1>Fedora&#8217;s Mission and Foundations</h1>

for the page itself, which is fine, but as

<title>Fedora&amp;#8217;s Mission and Foundations :: Fedora Docs Site</title>

for the title, which is not fine, because it causes the page title to be displayed as (literally)

Fedora&#8217;s Mission and Foundations :: Fedora Docs Site

mattdm commented Jul 30, 2018

* actually, 8217 (0x2019) is horribly wrong and the Unicode committee should feel shame. (ಠ_ಠ) But that is beyond the scope of this bug report.

Edited Jul 30, 2018 by mattdm

mattdm commented Aug 21, 2018

ping? this looks really bad.

pbokoc commented Aug 23, 2018

I talked to @asamalik; he says he's aware of the issue but that it will probably need to be fixed upstream. In the meantime, how about changing the title to something that doesn't contain an apostrophe or a mangled version of it? "Fedora Mission and Foundations", or maybe just "Mission and Foundations" (worse SEO but at least it would match the table of contents), ...

asamalik commented Aug 24, 2018

Reportred upstream: https://gitlab.com/antora/antora/issues/286

asamalik commented Aug 26, 2018

Fixed!

Preview: https://docs.fedoraproject.org/en-US/project/

The fix: https://pagure.io/fedora-docs/fedora-docs-ui/c/9033497218d7a03f9e5e0b8c2fc109566e39ff2f

Metadata Update from @asamalik:
- Issue assigned to asamalik

Aug 26, 2018

Metadata Update from @asamalik:
- Issue status updated to: Closed (was: Open)

Aug 26, 2018

mattdm commented Aug 27, 2018

Awesome -- thanks!