#2 fix line breaks in commands, mediawriter/liveusb-creator explanation
Merged by bex. Opened by zploskey.
fedora-docs/ zploskey/install-guide master  into  master

Download 2.patch

Lots of the commands were not displaying properly, with extra line breaks between commands and options or between a leading shell indicator character and the command. I think I fixed the lot.

The second patch attempts to clarify when the user will need to get mediawriter or liveusb-creatordepending on their Fedora version.

At first glance this looks great. I really appreciate the clean up.

I am not sure we need the Fedora 24 notes as that version is no longer receiving updates. Perhaps you could rework the patch to remove those references.

WDYT?

Awesome. I'm fine with removing the notes about f24.

2 new commits added

  • Update name of folder Fedora Media Writer appears in
  • Remove note about Fedora 24

Thank you.

Let me know if you'd like to talk about how to squash your commits in the future so that you could have fewer in each PR.

Unrelated - I've submitted your other commits for publishing and they should be live in an hour so. I am going to add add a few more commits along with this one and you should soon see this change on docs.stg.fedoraproject.org. It could be several hours though.

Pull-Request has been merged by bex

Thanks. Looks like changes made it to the live site. I'll make sure to squash commits next time. I usually don't squash until right before a merge on nontrivial changes so it makes things easier to review.

@zploskey fair point and a good workflow. In general, if your changes are highly related, it is ok to squash, in my opinion, at the time of first submission. here you fixed a bunch of white space and some other stuff so I respect having multiple commits.

Also, I didn't want to push back for you to squash and delay your PR merging. Next time you may not be so lucky and I may do that :P.

Thank you!

Metadata