#586 Fixes Issue 548
Merged by pbokoc. Opened by kborole.
fedora-docs/ kborole/release-notes iss548  into  f33

Download 586.patch

Ruby on Rails is updated to latest version 6.0 in Fedora 33.
Fixes issue #548

@pvalena @vondruch @jaruga can you please check the technical accuracy for the content?

Hi @kborole

I just reviewed the content itself only. I am not sure for example the file path is a proper and the adoc format is correct.

* Action Mailbox - It helps you to route incoming emails to controller-like mailboxes.
* Action Text - It displays Rails with rich text content and editing.
* Action Cable testing - This tools allow you to test your Action Cable functionality at connections, channels, broadcasts level.
* Parallel Testing - It help parallelize your test suites and reduce the time required for testing

I assume the content comes from https://edgeguides.rubyonrails.org/6_0_release_notes.html .

  • Seeing the original order of the items in the page. The order of the item is 1. Action Mailbox, 2. Action Text, 3. Parallel Testing, 4. Action Cable testing isn't it? Why did you change it?
  • I think the expression "It displays Rails with rich text content and editing." can be improved. It is not accurate. Because Rails is the web framework, it's not web site itself. For example I think "It displays a web site implementing Rails with ..." is correct. and "It brings rich text content and editing to Rails" in the source page is correct.

1 new commit added

  • Adding SME Review suggestions

Thanks @jaruga for the suggestions.

I assume the content comes from https://edgeguides.rubyonrails.org/6_0_release_notes.html .

Yes, I did refer the release notes along with the wiki page.

  • Seeing the original order of the items in the page. The order of the item is 1. Action Mailbox, 2. Action Text, 3. Parallel Testing, 4. Action Cable testing isn't it? Why did you change it?

I did not think this as a sequence because it states as "Major Features" and also in the wiki page does not talk or show anything about the sequence.
But i have made the changes, considering i might be misunderstanding.

  • I think the expression "It displays Rails with rich text content and editing." can be improved. It is not accurate.

Thanks for the suggestions. I have added them.

I appreciate your time for this :)

Okay. It looks good to me :)

rebased onto 3c3867bc6ddf2e884211735d7237707742c978a3

Pull-Request has been merged by pbokoc

LGTM, thanks!

Metadata