#33 %cargo_vendor_manifest fails with git dependencies
Closed by decathorpe. Opened by walters.

Using git dependencies fails; see https://github.com/coreos/rpm-ostree/pull/5227#issuecomment-2596922914


Is the format used in strings like 0.0.0 (https://github.com/containers/bootc?rev=dc7d4cf320ec6d8b2470d1d5f76da66ec60b6810#dc7d4cf3) documented somewhere?

It doesn't seem to be a pkgid: https://doc.rust-lang.org/cargo/reference/pkgid-spec.html

It shouldn't be too hard to adapt the generator to also work with strings like that, but I'd need to know the actual format before I can do that, obviously :)

It's output by the cargo tree invocation being used in the rpm macro is all I know off the top of my head.

OK well I do know one more thing...see https://github.com/coreos/cargo-vendor-filterer/pull/102 where we started parsing cargo tree and I had concerns about its output format design.

I think this code could parse cargo metadata instead, which is designed for machine consumption, there's crates to parse it etc

cargo metadata does not print all the information that cargo tree prints, though - it only includes direct dependencies, not transitive dependencies, doesn't it?

Also, the generator explicitly passes a format string to cargo tree to get a sane format, so I'm not worried about the default format.

(EDIT: Whoops, wrong button.)

Metadata Update from @decathorpe:
- Issue status updated to: Closed (was: Open)

Metadata Update from @decathorpe:
- Issue status updated to: Open (was: Closed)

This issue will be fixed by moving to cargo2rpm v0.3.0, which has more robust parsing rules for cargo-vendor.txt. This will accompany the v28 release of rust-packaging.

Metadata Update from @decathorpe:
- Issue status updated to: Closed (was: Open)

Metadata