#117 coreos-download: fix the misleading buttons in download page
Merged by dustymabe. Opened by abai.
fedora-web/ abai/websites coreos-download  into  master

Download 117.patch

The three buttons in the download page previously linked back
to the overview page, which caused confusion for the users:
https://github.com/coreos/fedora-coreos-tracker/issues/493#issuecomment-634222788

Instead, use only one button "View Release Notes" to link to the release notes
and the other three buttons for stream selector for downloads.

Closes: https://github.com/coreos/fedora-coreos-tracker/issues/493#issuecomment-634222788
Signed-off-by: Allen Bai abai@redhat.com

Demo

Today I've been trying to use the smooth functionality of scrollIntoView, i.e. element.scrollIntoView({behavior: "smooth", block: "start", inline: "start"}); but the behavior is very unstable (mostly in FireFox) and I highly suspect this is related to the async rendering of the page. Currently the change is to scroll to the navbar without scrolling animation.

cc @jlebon @dustymabe

As we don't yet have real release-notes, I think View Releases here would be fine enough.

Clicking this does not really download now :D
What about Browse images OR OS images or OS artifacts (or something similar) instead?

While I agree on dropping the dropdown, I think it's still valuable to keep some kind of visual hint to know which stream is currently being displayed.

Can we keep some element here with that content, and possibly matching the stream color?

Thanks for the review!

That makes sense. Will proceed with View Releases, Show Downloads as proposed in https://github.com/coreos/fedora-coreos-tracker/issues/493#issuecomment-635211659 and display selected stream.

rebased onto ba97c50efe09527954c37d8b54b5eb966d98162d

screenshot demo stable
screenshot demo testing
screenshot demo next

Updated as proposed, I was trying to figure out a way to give hint about the selected stream yesterday but I think this colored implementation looks really good.

@lucab could you take a second look?

@abai yes, I think that works.
To save a bit of vertical space too, you may consider re-arranging the "View Releases" button to be on the same line as this new stream hint (or having multiple ones next to each "Show Downloads").

Yes, this feels much better!

I think @lucab's idea of moving the "View Releases" button down, since it seems out of place as coming right after the introductory sentence.

Anyway, I wouldn't block on it if you want to tackle that as a follow-up.

~~Yes, I would prefer get this fix in first and do some experiment on the "View Releases" button as a follow-up.~~

/hold Will update with the View Releases bit

rebased onto b09279998fe3fb900275e39929348cb166da61a2

moved "View Releases"

Moved "View Releases" right beside the selected stream hint and removed the button styling so that it visually fits in with the line

LGTM, great rework!
I don't have merge access, so will leave it to e.g. @dustymabe or someone else to do a final review and merge.

Pull-Request has been merged by dustymabe

Metadata