fedpkg

#155 Add support for module commands
Merged by cqi. Opened by mprahl.
Unknown source master

Download 155.patch

This relates to https://pagure.io/rpkg/pull-request/254

Please note that I didn't test the zsh completion change since it seems like there is no official Fedora package to install that functionality. I tried to copy the syntax I saw from the other entries, but I'm not sure it is correct.

rebased onto 17ce38d3e66e23d9ab3f31d3ff626ea56cd920fa

rebased onto 56c666a99a2b1fd6ccf8f2b632d4199b4953bf80

These are also needed to add to fedpkg-stage.conf so that module commands work well with staging instances from fedpkg-stage.

Can notsecret be used in released fedpkg, or need to be replaced with a real OpenIDC secret?

Bash completion looks good to me. I think the ZSH completion is almost correct as well. The new commands should be added in _fedpkg_commands function (around line 400), and then it looks perfect to me.

This is the actual one used in production, so this is correct.

rebased onto 07268e48e95d48df63dfb7481eb060ee8b811f3f

Thanks for the review. I addressed your comments.

:thumbsup:

Pull-Request has been merged by cqi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.