Please let me know if its good and I will add some comments

Thanks, @mohanboddu, I am open to merge it. Do you want to add some additional code/comments?

So "epel\d-playground" is a correct branch name, right? There was a discussion about it at https://pagure.io/fedpkg/issue/334

@onosek, I am making adjustments to this PR, since we decided to automatically request epel\d-playground when someone requests epel\d.

PR will be updated with notes in few min.

onosek yes.. epel\d-playground is the correct name. when we get to epel10 in 2026 it will be epel\d+-playground

Why is this None here but boolean later? Shouldn't it be False?

Why is this None here but boolean later? Shouldn't it be False?

Sorry it got carried from my previous patch, it should be false, you are right.

I think we should probably consider disallowing epel\d+-playground from being requested specifically as well. We don't want to allow a situation where only that one is available.

Right now, if I read this correctly, if someone did fedpkg new-branch epel8-playground, epel_playground would be False and it would create a module branch called epel8-playground, which we don't want.

I think we should expressly disallow requesting epel\d+-playground branches and allow them to be created only alongside epel\d+.

I think we should probably consider disallowing epel\d+-playground from being requested specifically as well. We don't want to allow a situation where only that one is available.

Fixed.

LGTM now.

@onosek Please review it now and let me know, thanks.

A colon is missing. This is why unittests are failing.

A colon is missing. This is why unittests are failing.

Thanks @onosek , it has been fixed now.

minor - epel\d+-playground. A dash is missing.

'+' should not be at the end of the expression but behind the '\d'.

Minor. Add '+' behind '\d'. Or use *-playground.

@mohanboddu I am sorry for later review. I had to leave early on Friday.

@mohanboddu I am sorry for later review. I had to leave early on Friday.

I updated it with your comments.

@onosek I added the check for epel7, as we are planning to roll it initially to epel8 only.

We need to remove it later when we enable it for epel7

I am not completely sure, what is the purpose of this. But this construction probably needs comparison with a string like '7' (it is currently integer).

BTW thanks for updates for my comments.

I am not completely sure, what is the purpose of this. But this construction probably needs comparison with a string like '7' (it is currently integer).

We are only enabling it for epel8 for now and we will definitely have it for epel9 and onwards.

I dont know when we will enable it for epel7, hence the check.

I changed it to int to check the versions, Thanks for the catch, not in a good day today.

Commit eabb5ae7 fixes this pull-request

I did some additional modifications in the commit eabb5ae7. But the result should be the same. I also prepared some unittest for this functionality. Thank you for the contribution, @mohanboddu.

@onosek Yeah, I was trying to avoid change at multiple places when we enable it for epel7, thats all :smile:

I am not completely sure, what is the purpose of this. But this construction probably needs comparison with a string like '7' (it is currently integer).

We are only enabling it for epel8 for now and we will definitely have it for epel9 and onwards.
I dont know when we will enable it for epel7, hence the check.
I changed it to int to check the versions, Thanks for the catch, not in a good day today.

@mohanboddu, I have a additional question. @lsedlar mentioned something which I didn't realize. Currently, the code enables 'epel_playground' for epel branches including version 7 and next. There is an uncertainity, if I have to release as it is and epel_playground will be enabled for epel7. What is a plan for this?

OK thanks for the info. The idea is to have epel7-playground out in the fall after we have gotten epel8 and epel8-playground out the door. The goal would be to follow what we did in epel8 so workflows and tools are the same.