fedpkg

#99 Set disttag properly
Merged by cqi. Opened by cqi.
cqi/fedpkg set-disttag-properly  into  master

Download 99.patch

In fedpkg, load_rpmdefines does not set self._disttag, not like what
pyrpkg does. This causes disttag cannot return a correct value, and any
method using disttag in pyrpkg does not work in fedpkg.

Signed-off-by: Chenxiong Qi cqi@redhat.com

Do you have any specific example of what does not work without this patch?

One example is in my local development branch I haven't made a PR for it so far. It uses self.disttag. Without this patch, self.disttag will always return None. I'll make a PR for that change later.

Anyway, load_rpmdefines should not change Commands.dist, which is not used for dist macro. Instead, Commands.dist should be changed by option --release or the deprecated --dist.

It looks good to me. I was just curious how come this has not caused any problems so far.

rebased

Looks good to me.

Pull-Request has been merged by cqi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.