Fix for https://pagure.io/releng/issue/8844

This looks good to me. It'd be nice to have a unit test for it though.

Does this allow branch requests by provenpackagers? Should it?

It shouldn't.

lgtm

It shouldn't.

@kevin Do you think we should add that? If we should add it, how can I access the list? FAS?

Well, there has to be a way to handle:

1. When a branch is urgently needed to fis some issue (perhaps release blocking?) If releng has a way to override this would work in that case.

or

1. When someone requests a branch and the maintainer hasn't reploied in X amount of time (I think we used to give them 2 weeks in the past). I'm not sure how to handle this case. We could leave the ticket until it's 2 weeks old or wharever, but then we don't really know if the maintainer answered and said no, don't do it, or not.

So, perhaps this entire workflow needs more discussion?

Well, there has to be a way to handle:

When a branch is urgently needed to fis some issue (perhaps release blocking?) If releng has a way to override this would work in that case.

This part is already handled in the patch, you can force to skip the maintainers check.

or

When someone requests a branch and the maintainer hasn't reploied in X amount of time (I think we used to give them 2 weeks in the past). I'm not sure how to handle this case. We could leave the ticket until it's 2 weeks old or wharever, but then we don't really know if the maintainer answered and said no, don't do it, or not.

So, perhaps this entire workflow needs more discussion?

Yeah, this requires more discussion.

I'd say we can start as is because this is currently impacting some of our packagers and figure a way to rework it later.

+1 to just adding this now to fix many issues and revisit if we want to make more. ;)

@mohanboddu can you rebase?