Signed-off-by: Mohan Boddu mboddu@bhujji.com
This is a WIP, it needs more testing.
But review is appreciated.
Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
Is this a good way to do it? I think we should just use data from the ticket and not introduce complexity when not needed.
I thought about it when working on it, but then what if they changed the ticket to create blah instead of rawhide branch in rpms namespace, for modules they are getting what they are asking for.
blah
rawhide
Or maybe just see what they requested and if it is not the default, then close the ticket saying that the branch requested is not the default branch?
Well, this doesn't work too, i think we should create the default branch and the requested branch. So, we should leave it as is.
1 new commit added
Warning message in repo reqs if the requested branch is not the default branch
Close the ticket if the requested default branch is master
Or maybe just see what they requested and if it is not the default, then close the ticket saying that the branch requested is not the default branch? Well, this doesn't work too, i think we should create the default branch and the requested branch. So, we should leave it as is.
Well, what I mean is that the default branch value could be part of the json/issue body. That would drop some of the complexity and we will just process every json the same way. Create default branch and requested branch.
Or maybe just see what they requested and if it is not the default, then close the ticket saying that the branch requested is not the default branch? Well, this doesn't work too, i think we should create the default branch and the requested branch. So, we should leave it as is. Well, what I mean is that the default branch value could be part of the json/issue body. That would drop some of the complexity and we will just process every json the same way. Create default branch and requested branch.
It could be here or in fedpkg, I prefer it being here as we have more control over it than fedpkg. Also, having default_branch and branch_requested in the json might be confusing.
default_branch
branch_requested
Or maybe just see what they requested and if it is not the default, then close the ticket saying that the branch requested is not the default branch? Well, this doesn't work too, i think we should create the default branch and the requested branch. So, we should leave it as is. Well, what I mean is that the default branch value could be part of the json/issue body. That would drop some of the complexity and we will just process every json the same way. Create default branch and requested branch. It could be here or in fedpkg, I prefer it being here as we have more control over it than fedpkg. Also, having default_branch and branch_requested in the json might be confusing.
Ok.
I have used your PR code and build RPM from it locally to test it. When processing issue the result repo has default branch main and branch rawhide was created from it. Is this the expected result? What is strange is that another issue failed with invalid JSON. The tickets seem to be the same except for the repository name.
rebased onto 26a96aff83b8706ee355a5938ba49f61265a5a99
Pull-Request has been merged by mohanboddu
Signed-off-by: Mohan Boddu mboddu@bhujji.com