filesystem

#2 add ownership of /run/{motd,motd.d} and /usr/lib/{motd,motd.d}
Closed by mosvald. Opened by rfairley.
rfairley/filesystem rfairley-motd-own  into  master

Download 2.patch

This adds ownership of the two directories /run/motd.d and /usr/lib/motd.d and two motd files /run/motd and /usr/lib/motd, which completes ownership of the default motd paths that PAM is now using [1]. Tested installation using the RPM on the fedora/29-cloud-base Vagrant box built in COPR: https://copr-be.cloud.fedoraproject.org/results/rfairley/add-motd-directories/fedora-29-x86_64/00836610-filesystem/, and works as expected.

The /run/motd and /usr/lib/motd files are treated like config files, but I'm thinking it makes sense to keep them in filesystem rather than setup if the motd.d directories are here. To include the files, I needed to add a stub file as a source for each (run.motd and usr-lib.motd) - I appreciate any suggestions for other approaches.

I noticed https://src.fedoraproject.org/rpms/filesystem has a specfile one release higher than this is currently, can also open the PR there if needed.

[1] https://github.com/linux-pam/linux-pam/pull/69

Thanks for PR - my slight preference would be to keep filesystem package directory only - and have the files owned by setup package. Do you have any reason why filesystem package is better place? It doesn't really matter too much, as they are both "very soon installed" packages and I maintain both of them.

My initial thought was to go with filesystem for the /run/... and /usr/lib/... directories as setup looked to mostly have /etc/... files/directories - but either setup or filesystem is good (and setup would be nice to have all the motd-related paths in one place).

I'll take a look at getting the files into setup - I think I can just copy the same motd file with cp -a motd %{buildroot}/run and cp -a motd %{buildroot}/usr/lib which fits with https://pagure.io/fork/rfairley/setup/blob/rfairley-etc-motd-dir-own/f/setup.spec#_34. Will try this out.

Yes, it owns the dirs - but filesystem is supposed to be "directory hierarchy" only - so setup fits better from this perspective. And I agree it would be better to have all files motd related files at one place... and there is already one /var file in setup package, so it is not solely /etc :)

Opened a PR at setup: https://pagure.io/setup/pull-request/15

Metadata Update from @ovasik:
- Request assigned

I believe this PR was fully satisfied with the below 2 setup commits:

https://pagure.io/setup/c/f4f7bdc8793b362566591421bc55211e4c517295
https://pagure.io/setup/c/dd1c0094a6eef681e34f7ae49fc9bf3392da4a70

so closing this without merging.

Please, if there are still some changes that you wish to happen in filesystem, please open a new PR. Thanks!

Pull-Request has been closed by mosvald
Metadata
mosvald
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.