flatpak-module-tools

#27 build_scheduler: format links to failed and canceled builds
Merged by otaylor. Opened by yselkowitz.
yselkowitz/flatpak-module-tools main  into  main

Download 27.patch

The string is not currently being formatted, resulting in e.g.:

ModemManager: {weburl}/taskinfo?taskID={task_id} failed

rebased onto a4b848fe40da2b2e4f7e0f0bbd141478179f0327

Hmm, if I'm not mistaken, this is going to result in a failed state looking something like:

 libfoo: [123456] failed
      [123456] build failed
          [123457] buildSRPM closed
          [123458] buildArch (x86_64) failed
          [123459] buildArch (ppc64) cancelled

Maybe just omitting the task ID / link would be better? Do you have a screenshot of what it looks like after this commit?
Edited by otaylor

Merging this as is, since I want to do a release. If you agree with me that this results in too much duplication (and I haven't tried it out), then we can change that later.

Pull-Request has been merged by otaylor

@otaylor it does seem to be duplicate information, but that seemed to be the desired outcome of the code in its current state, hence this PR. I don't think we can reliably get NVR at this stage (since the build could fail early before an NVR is assigned), so its either the task ID or nothing. Not sure that I particularly care either way except not to have it unformatted as it was.

I think the attempt to put the task URL there came from an earlier version of the code before there was the task tree with linkified IDs. Doesn't really matter - if it bugs me, I'll change it when it does. Thanks for the fix!
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.