freshmaker

#122 Refactor code
Merged by jkaluza. Opened by cqi.
cqi/freshmaker refactor  into  master

Download 122.patch

This PR contains two commits that refactors part of the code of finding images in ErrataAdvisoryRPMsSignedHandler and LightBlue.

  • Split _find_and_record_images_to_rebuild
  • Simplify code that converts found images to batches for rebuild

rebased onto f5cfd5755d181ca0c23b5e7e341c99e3f950dd8d

1 new commit added

  • Simplify code that converts found images to batches for rebuild

I do not think this will remove the duplicate images. I guess what you were trying to do here is:
if image_key not in batches:
batches[image_key] = image

I would like to see a test to cover this behavior.

I would like to see a test to cover this behavior.

This is already covered in test within this patch.

Okay, I got it.

So it might be good to use a comment here to describe the duplicate images are removed as expected.

rebased onto 010a099a3b59e5203794b79aee5bb387afa8a7a4

Add more comment to describe the code and rebased. Ready for review.

@mjia PTAL.

I guess you mean dependent image.

I'm not quite sure how this test works though, but the syntax looks okay to me. Having said that, it would be good for someone who is familiar with freshmake to review this logic again.

Pull-Request has been merged by jkaluza
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.