freshmaker

#146 Freshmaker-cli improvements: support all current event types, show even state/state_reason, allow filtering based on states
Merged by jkaluza. Opened by jkaluza.
jkaluza/freshmaker empty-content-sets  into  master

Download 146.patch
no initial comment

Why not implement this filter directly on the API? That would save you a lot of queries and speed things up significantly.

You can see this PR in MBS for inspiration:
https://pagure.io/fm-orchestrator/pull-request/813

As mentioned in the in-line comment, I think the filtering should occur through arguments on the API and not through code on the client. In the meantime, this is ok though.

+1

Yeah, I plan to improve the API too, but for now I need to query deployed freshmaker, so this is kind of hotfix.

Commit 910c5792 fixes this pull-request

Pull-Request has been merged by jkaluza

Pull-Request has been merged by jkaluza
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.