#162 Install Koji via setuptools
Merged by jkaluza. Opened by cqi.
cqi/freshmaker install-koji  into  master

Download 162.patch

Since version koji-1.15.0, koji is installable via setuptools, we do not need sitepackages to provision environment for running tests from now on.

I do not think you need these three print statements.

As I remember, ' dependency_links' is deprecated. You should be able to use install_requires as they way used in Greenwave.
https://pagure.io/greenwave/blob/master/f/setup.py#_32

Good catch. They exist only for debugging purpose. Thanks.

I searched again from internet, and didn't find dependency_links is deprecated. Even in setuptools documentation, it is not mentioned. I probably missed something. But, so far, dependency_links really works well. :)

Regarding the greenwave case, at line 32, package name is extracted from URL and put into install_requires, rather than putting URL with prefix git+ into install_requires. This does not work for freshmaker because koji hasn't been published to PyPI. I have documented that in commit message. So, at this moment, we can leverage the latest setuptools support for freshmaker to provision testing environment without waiting for the publish.

rebased onto bffa240bb7b96d1aa9186cadc77e644c0c255a50

Okay, I must have been messed up. LGTM, :thumbsup:

Looks good to me. I've also tested it works when building on epel7.

Commit f8bf4235 fixes this pull-request

Pull-Request has been merged by jkaluza

Pull-Request has been merged by jkaluza

Metadata