Seems fine to me from a read-through.

It looks like jenkins is unhappy with rpm-software-management :( I think I saw @mprahl hit this issue elsewhere in the MBS code (specifically fm-orchestrator#828).

@ralph @mprahl I filed an issue https://github.com/junaruga/rpm-py-installer/issues/104

This should be openidc if ODCS_SERVER_URL is fedora instance. But we don't have any ODCS token for Freshmaker, so I don't know. I would rather change odcs.fedoraproject.org URL to something general.

Or you can add odcs_openidc_token and pass it to ODCS client class later. Even we don't have that token right now for Freshmaker Fedora, it will make sense to have odcs_openidc_token variable.

+1 generally, I would only like to see the config options to be consistent as I described in inline comment.

I would rather change odcs.fedoraproject.org URL to something general.

Do you mean to give it a fake URL?

Yes, +1.

Commit b0b11c31 fixes this pull-request