From 6a036f54a6916982cad72bfe7f8b879bb92e1746 Mon Sep 17 00:00:00 2001 From: Chenxiong Qi Date: Jan 09 2018 01:29:38 +0000 Subject: Fix raw sql in migration This fixes the raw SQL constructed manually by string concatenation. Fixes #166 Signed-off-by: Chenxiong Qi --- diff --git a/freshmaker/migrations/versions/90f8444d5ab7_add_event_state_and_timestamp.py b/freshmaker/migrations/versions/90f8444d5ab7_add_event_state_and_timestamp.py index 4ed5c29..fd3c5d0 100644 --- a/freshmaker/migrations/versions/90f8444d5ab7_add_event_state_and_timestamp.py +++ b/freshmaker/migrations/versions/90f8444d5ab7_add_event_state_and_timestamp.py @@ -13,6 +13,7 @@ down_revision = '2f5a2f4385a0' from alembic import op import sqlalchemy as sa +from freshmaker.models import Event from freshmaker.types import EventState @@ -23,7 +24,11 @@ def upgrade(): batch_op.add_column(sa.Column('time_created', sa.DateTime(), nullable=True)) # update state to 'COMPLETE' for historical events - op.execute("UPDATE events SET state = %s" % EventState.COMPLETE.value) + op.execute( + sa.update(Event).values({ + 'state': op.inline_literal(EventState.COMPLETE.value) + }) + ) def downgrade():