freshmaker

#189 Set _FAKE_COMPOSE_ID to proper value in DRY_RUN mode to keep the odcs_compose_ids unique and increasing.
Merged by jkaluza. Opened by jkaluza.
jkaluza/freshmaker get_image_builds_in_first_batch-fix  into  master

Download 189.patch

In dry_run mode, we are not talking to ODCS and instead fake the compose. But when doing, so, we have to generate unique compose id.

LGTM.

Is it ok to return 0 when no compose have been found? As i understand the compose_id identifies the compose in the db, with this it looks like a compose with id 0 exists. Wouldnt be None a better return value?

rebased onto 29c18a08336b79f96e52569dac0fdd625e46661f

Rebased, added comment about returning 0.

Pull-Request has been merged by jkaluza
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.