#21 code refactor and feature of rebuilding modules when rpm spec is updated
Merged by qwan. Opened by qwan.
qwan/freshmaker rebuild-modules-on-rpm-spec-change  into  master

Download 21.patch

Note: the feature of rebuilding modules when rpm spec is update requires this PR https://github.com/fedora-modularity/product-definition-center/pull/15 in pdc to support filtering modules by rpm name and branch.

If change kwargs to something like query_params, it would be more straightforward and easy to understand.

Should these params be the docstring of __init__?

It would be nice to make RPM name more clear?

Generally LGTM

rebased

Just realized it's unnecessary to add a new rpm handler, should add such feature which need to trigger MBS rebuild job in mbs handler to keep it simple, updated.

FYI, https://github.com/fedora-modularity/product-definition-center/pull/15 is merged but currently isn't scheduled to be deployed until next sprint (so we can wait for one more change from @mprahl). If having it in place is urgent, let me know and I can fast track deployment.

Pull-Request has been merged by qwan

It seems like this is an irrelevant change.

s/update/updated

It would be good to log a message here for debugging purpose, similar to
the one in def handle_metadata_update.

@mjia Thanks for reviewing, it was merged :( but luckily these issues won't break the functionalities, so I can update them in later patches :)

Metadata