freshmaker

#222 Fix module build handler
Merged by jkaluza. Opened by qwan.
qwan/freshmaker fix-module-build  into  master

Download 222.patch
  1. When module metadata updated and module has been built in MBS with that revision, we should just ignore it
  2. Fix parser to only produce event when metadata is changed

rebased onto 4b4c031f2ac80b761a727de7a5e71dafc0be8b40

Updated to generate random git hash string instead of the hardcod all-zero string.

Should this be a fixed name modulemd.yaml?

It's .yaml, for example: https://src.fedoraproject.org/modules/testmodule/tree/master

On Tue, Feb 13, 2018 at 5:06 PM, Qixiang Wan pagure@pagure.io wrote:

qwan commented on the pull-request: Fix module build handler that you are following:
It's <name>.yaml, for example: https://src.fedoraproject.org/modules/testmodule/tree/master

Ok. This looks good for me.

To reply, visit the link below or just reply to this email
https://pagure.io/freshmaker/pull-request/222

--
Regards,
Chenxiong Qi

hm, I can't recall whether there was any discussion happened before on 'module metadata change', @jkaluza could you confirm we should response only when the metadata yaml changed? or should response on any change to the repo?
The issue was reported as #221, and fix in this PR (the 3rd commit).

@qwan: I will ask others, for now lets keep the modulemd change only.

rebased onto 0d0abbebaa19ccb5e7e2b6bfcbd1a074664dadde

Rebased to drop dry-run commit from this PR.

Pull-Request has been merged by jkaluza
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.