freshmaker

#233 Add dry run mode for module build
Closed by ralph. Opened by cqi.
cqi/freshmaker dry-run-in-class-MBS  into  master

Download 233.patch

Signed-off-by: Chenxiong Qi cqi@redhat.com

This PR contains changes of adding dry run to module build related code. Low level methods can dry run without cloning from dist-git or requesting a real module build in MBS. Also, MBSModuleStateChangeEvent is returned for each "built" module in oder to dry run MBSModuleStateChangeHandler.

If this is acceptable, I'll close my previous pr #219

rebased onto 1d75ceb2b5996bb9a22fef52d4621784d643db8a

rebased onto 434e666ec1496f8464cef9fd11bd36568153ee58

1 new commit added

  • Add tests for some methods in utils.py

A few test cases are added in a separate commit that cover the added dry run in some utils methods.

2 new commits added

  • Add tests for some methods in utils.py
  • Add dry run mode for module build

Why not to clone the repo in dry_run mode? It does not change the remote repo anyhow, so it is safe to do it and it can help finding out some misconfiguration or missing permissions.

In case we allow cloning in dry run mode, the changes to this method can be removed, right?

Closing this same as #219 to get it out of the PR queue. @cqi, let's re-open it after the ursa work wraps up.

Pull-Request has been closed by ralph
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.