freshmaker

#292 Convert security data api to a bugzilla api.
Merged by ralph. Opened by ralph.
ralph/freshmaker no-more-sec-data  into  master

Download 292.patch

Turns out we have a race condition with the security data api. It only gets
updated an hour or so after the advisory ships and we get triggered. This
means that in practice, freshmaker would never trigger since it would always
come up with "unknown" for the severity on any event.

This moves the code to query bugzilla instead, which is the source of the
severity information.

Note that we don't need to make an authenticated query to bugzilla since PST assures us that the bugs will be public before the advisory which triggers us can go SHIPPED_LIVE.

Is it possible for the root to not have children? If yes, then probably this can be put in a try?
Edited by yashn

Yeah, or catch it outside this call in the other method. Good idea.

I think it should always have children... but, better to be safe.

rebased onto 92e2c170f32ee3afed4cc69918ce1f3d17eab888

Rebased. :)

This code looks good to me. I haven't had a chance to get the unit tests fully running (still working on getting them set up correctly on my end), I'll assume you've run them.

:thumbsup: :ship:

Pull-Request has been merged by ralph
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.