#314 New: About API
Merged by fivaldi. Opened by fivaldi.
fivaldi/freshmaker fivaldi_about_api  into  master

Download 314.patch
no initial comment

These 2 new imports could be merged with all the others before into a single import statement. Yes/no?

Somebody has some ideas on some interesting config items to be exposed here?

Greenwave has only version but WaiverDB provides info on authentication method: https://waiverdb.engineering.redhat.com/api/v1.0/about

Maybe auth_backend makes sense for freshmaker. This can be: noauth or openidc

rebased onto 4411513925cd6a9ff7ba2a792335978b63a40699

@lholecek I put auth_backend here..

Code looks good for me. But I have a different thought about raising ProgrammingError from AboutAPI.get.

Let's see a case. An incorrect config is added to config_items, then freshmaker is released. When about API is called at some time after the release, client gets a bad request which represents the raised ProgrammingError. This shouldn't make sense. Instead, it would be good to catch the invalid config added to config_items during development. An assert could be appropriate for that.

rebased onto e4f0384bb2b6a2b61af90b6c16a8a8c730ca7a03

@cqi, thanks for pointing it out, I used ValueError instead.

rebased onto 37df20febef9a9f991d8c615d4e7ae315cce0a25

:+1: LGTM

Pull-Request has been merged by fivaldi

Metadata