:thumbsup:

+1 - but do you already have things in place to make sure you don't diverge from standards again? Commit hooks and/or CI I mean

+1 - but do you already have things in place to make sure you don't diverge from standards again? Commit hooks and/or CI I mean

Not yet, usually I will run flake8 checking before push the commits, but not always. I'm not sure whether we can enable git hooks in central or push them to remote, probably not. It will just be an recommendation for devs to enable local pre-commit hook to run flake8 check, and for reviewers can run the checks too while reviewing a PR.

In #19, '--exit-zero' has been remove from the flake8 cmd, so I guess CI will enable this check after it merged. Seems something wrong with jenkins.fedorainfracloud.org at this moment, so can't check this.

ignore_outcome = True ignores the failure of flake8, when any issues detected by flake8, tox will not fail. To ensure not diverge from standards again, it looks that option should be removed as well.

ignore_outcome = True ignores the failure of flake8, when any issues detected by flake8, tox will not fail. To ensure not diverge from standards again, it looks that option should be removed as well.

Could you comment on #19 too? so we won't forget it.