freshmaker

#322 Request ODCS compose with all RPMs installed in the *unshipped* container image.
Merged by jkaluza. Opened by jkaluza.
jkaluza/freshmaker odcs-builds-source  into  master

Download 322.patch

So far, Freshmaker rebuilds just shipped container images, but for release-driver
use-case, it needs to be able to rebuild also unshipped container images.

Such images can contain unshipped RPMs, so our normal way of getting them from
Pulp repositories defined by content sets will not work - Pulp repos don't
contain unshipped RPMs.

In this PR, we therefore request ODCS compose with all the RPMs installed
in the unshipped container image and use it together with Pulp repos. Using
this approach, unshipped container image can get even the so-far unshipped RPMs.

Would it make sense to check for the state that we want? In this case it can only be done. If it's removed for example, OSBS won't know to regenerate it because a URL is given and not the ODCS compose ID.

*built

This could be simplified:

if not image.get('rpm_manifest'):
  ...

This could be simplified:

if not rpm_manifest.get('rpms'):
  ...

rebased onto 508ced96d56e9228fa7af515652bd67d05ddad34

Updated.

:+1:

Thanks for the review.

I will merge it on Monday after ODCS upgrade, so we won't get freshmaker-dev with this feature enabled and old ODCS where this feature is not supported...

Commit ff5ce9f6 fixes this pull-request

Pull-Request has been merged by jkaluza

Pull-Request has been merged by jkaluza
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.