PR#332: Fix some flake8 and bandit issues -

freshmaker

#332 Fix some flake8 and bandit issues

Merged Dec 4, 2018 by lucarval. Opened Nov 27, 2018 by cqi.

cqi/freshmaker fix-flake8-and-bandit-issues into master

Download 332.patch

no initial comment

2 new commits added

Fix issues reported by bandit
Fix flake8 errors

Nov 27, 2018

lucarval commented Nov 27, 2018

I don't think this package is properly packaged internally.

cqi commented Nov 28, 2018

I don't think this package is properly packaged internally.

There is version 0.5.0 package built in internal. ODCS requires defusedxml as well. You could find out those packages in page /packageinfo?packageID=42520 in Brew. I'm not sure if the required python-defusedxml by odcs is that el7 one, but we can rebuild it for eng-rhel-7 or just tag that build.

lucarval commented Nov 30, 2018

:+1:

We now use fedora 28 based container images anyways. So this shouldn't be a problem.

Edited Nov 30, 2018 by lucarval

lucarval commented Nov 30, 2018

@cqi, this has merge conflicts now.

lucarval commented Dec 3, 2018

@cqi, the flake8 errors are preventing the release from proceeding :( could you take a moment to resolve the merge conflicts?

rebased onto 757586251c31de76db0324f8efee937bc7b1fd4f

Dec 4, 2018

cqi commented Dec 4, 2018

@lucarval Done. Sorry for late.