PR#351: Generate Pulp repos in case we are generating extra ODCS compose for unpublished image. -

freshmaker

#351 Generate Pulp repos in case we are generating extra ODCS compose for unpublished image.

Merged Jan 29, 2019 by jkaluza. Opened Jan 23, 2019 by jkaluza.

jkaluza/freshmaker spec-fix into master

jkaluza commented Jan 23, 2019

In case when image is unpublished, we need to generate an extra ODCS compose with
possibly unpublished RPMs which exist only in Koji so far.

We can pass this extra compose to Koji using "compose_ids" build option.

But the issue is that when "compose_ids" is set, Koji/OSBS completely ignores the
Pulp repos defined in the content_sets.yml file and it overrides it by whathever
we passes to it using compose_ids.

Because of that, we need to generate also the Pulp repos on Freshmaker's side
in this case and pass it together with extra compose in the compose_ids.

yashn commented Jan 25, 2019

The test name states that it should not generate_pulp_repos but the last line of this test checks if prepare_pulp_repo is called. Am I missing something here?

Edited Jan 25, 2019 by yashn

jkaluza commented Jan 28, 2019

The test name is wrong. It's copy-paste issue from older test. I will rename it.

rebased onto f31238ed3c29e064ef7aca2b1644d857b709781a

Jan 28, 2019

jkaluza commented Jan 28, 2019

Updated.

lucarval commented Jan 28, 2019

:+1:

yashn commented Jan 28, 2019