#377 Do not treat ODCSComposeNotReady as error which fails ArtifactBuild.
Merged by jkaluza. Opened by jkaluza.
jkaluza/freshmaker errata-retry-kerberos  into  master

Download 377.patch

When compose is not done yet, the BaseHandler raises ODCSComposeNotReady
exception. This is supposed to be catched by the start_to_build_images,
which pauses the rebuild until the ODCS compose is ready.

The issue is that fail_artifact_build_on_handler_exception decorator
also catches this ODCSComposeNotReady exception and marks the ArtifactBuild
as FAILED. This is wrong, because ODCSComposeNotReady exception is expected
and should not mark the build as FAILED.

This commit fixes it by introducing the whitelist kwarg in the
fail_artifact_build_on_handler_exception decorator and whitelists
the ODCSComposeNotReady exception, so it does not move the build
to FAILED state, but instead just re-raises the exception so it
can be handled in start_to_build_images.

This if is the only code added here. Other changes are just in indentation.

Commit e0f19645 fixes this pull-request

Pull-Request has been merged by jkaluza

Pull-Request has been merged by jkaluza

Metadata