#386 Add support for manual dependent rebuilds on existing events
Merged by jkaluza. Opened by yashn.
manual_dependent_rebuild  into  master

Download 386.patch

Allows users to submit manual Freshmaker event which will be based on the existing Freshmaker event.

I was wondering if there's a better alternative to support fetching an event by event_id

@jkaluza Can you PTAL?

Maybe just simply add another method get_by_id or get_by_event_id.

Yeah, I think get_by_event_id would make sense.

This looks good, I think what @cqi suggested with get_by_event_id makes sense. Once this is done, +1 to merge.

Hm, not sure why tests failed here in unrelated part of code. Let's see if it fails also on rebase later.

rebased onto c73a853c260fec51551b931a06b587e42c48a4ca

Thank you @cqi and @jkaluza, I made the changes. Can you PTAL? :)

pretty please pagure-ci rebuild

Tests are passing now :). merging.

Commit bbceca2f fixes this pull-request

Pull-Request has been merged by jkaluza

Pull-Request has been merged by jkaluza

Metadata