#392 Do not mark the event failed in-case of a service failure
Merged by jkaluza. Opened by yashn.
alert_on_service_failures  into  master

Download 392.patch

rebased onto cc7464b668904ec5bb740c32335c97108e247bbf

@jkaluza Please note, I had to remove @fail_event_on_handler_exception decorator from the handle method. It doesn't break the tests but I just want to make sure that it doesn't affect a corner case. :)

@yashn, hm, I see, the exception is re-raised by the fail_artifact_build_on_handler_exception and handled again by fail_event_on_handler_exception which marks whole event as failed.

I think for now let's do it the way you did it here. I will create another card to make this kind of nesting possible, because I think the same issue can appear also in other parts of code.

Commit 067b2b4c fixes this pull-request

Pull-Request has been merged by jkaluza

Pull-Request has been merged by jkaluza

Metadata