@jkaluza can you please check? Are the conditions of the test sufficient?
cc. @yashn

We have discussed this on IRC, no need for further reviews right now.

Small issue with current implementation is that the ArtifactBuild representing the parent_nvr in the db_event stays in the db_event even when it is reused and nothing is really built against it. Giulia will work on fix and update the PR after that.

@jkaluza I think it's complete now. PTAL

Suggestion: Consider implementing this logic in Event class directly to avoid code duplication:

class Event(FreshmakerBase):
  ...
  def get_artifact_build_from_event_dependencies(self, session, nvr):
    for parent_event in self.event_dependencies:
      ...
      return parent_build
    return None  # Implicitly

Why do we need to query the database again?

Why do we need to query the database again?

Ah! It's because we query with the nvr, then parent_nvr.

+1, can you do it this way @giulia?

I will let the apprentice to answer that :-P.

@lucarval The first query handles the fact that the original parent should not be created at all. The second part of the part changes how the child image gets created.
Without the first part we are still creating the parent, that would still be built by Freshmaker even if it's not necessary, because there's no child depending on it.

@jkaluza are you satisfied with the apprentice reply? :D

@jkaluza @lucarval I've rebased with the suggestion. Could make another review? Thanks.

Add docstring please stating that nvr is used as original_nvr when finding the ArtifactBuild.

Commit 0c4b8cb4 fixes this pull-request