freshmaker

#40 Errata class and build_signed(...) method
Merged by cqi. Opened by jkaluza.
jkaluza/freshmaker errata  into  master

Download 40.patch

I'm thinking, if we should use Errata-tool library or just live with python-requests + requests-kerberos. It seems we won't be doing anything else than the few GETs. Is it worth introducing errata-tool dependency for these?

:thumbsup:

At current stage, I would vote to use python-requests.

OK, I will clean the code a bit and remove the WIP and it should be done. I will also replace the ErrataBridge even with the BrewSignRPM.

Could you add rename it to add 'Event' at the end? since we have all event names ending with 'Event', parsers ending with 'Parser' and 'Handler' for all handler names in current code.

Yes, I have to rebase it to your refactor PR.

rebased

rebased

It's ready for review :)

This method returns a list of advisories, not only IDs.

It would be good to keep two blank lines before class statement.

rebased

rebased

Fixed cqi's comments.

There are some flake8 errors detected in the patch, you can run 'tox -e flake8' to see the details.

I think we need to enable flake8 test on jenkins, @jkaluza do you know who has the admin rights for freshmaker project on jenkins or should we issue a ticket to fedora-infrastructure? It's better to give us the admin/configure rights.

rebased

I've enabled flake8 there and rebased to test it... let's see.

rebased

Fixed the flake8 bugs... I also fixed that for lightblue.

+1

+1

Pull-Request has been merged by cqi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.