#411 Add devel documentation about container images rebuild.
Closed by gnaponie. Opened by jkaluza.
jkaluza/freshmaker depends  into  master

Download 411.patch
no initial comment

rebased onto 47fb15c26feff94c06fec7a14204af54b3461327

@srieger, @yashn, @gnaponie, could you please review this?

In case you are going to submit grammar fixes, can you please do it in form of diff (just fetch my fork, edit the file and send git diff output)?

I'm gonna post a diff later. I'm not sure about it, so I'm not going to include it in it: does "Lightblue" need the article before it?

It should be "exact" instead of "exactl", I'm gonna fix that in the diff I'm gonna post.
But you could just write "same", removing exact, because it's redundant to put both "exact" and "same".

Optional: it is really annoying to review the PR with such long lines :D could you put some new line when the line is too long?

I don't understand what you mean with "which yum install it.".

This sentence confuses me...
When determining the parent of the last affected parent image --> is that the parent of the parent? overwhelming...
Freshmaker tries to use the latest published parent --> which parent are we talking about here?
it just uses the original parent image of this last affected parent image --> I'm lost again.

That's my diff for the grammar, but I might also make mistakes, so someone else should review my diff too :)
https://paste.fedoraproject.org/paste/R1oemXTIZl1n6AJ1eO1wDg

Can we list here examples of the architectures?

Can you expand a bit what "squashed" means in this case?
And why did this get "squashed"?

Can we put here an example of "Koji target"?

Every image in published affected images squashed --> Every image in published affected images is squashed
Sorry, I think I forgot to put it in the diff

What and where is this method?

Do we still want this?

I'd like to keep this.

Let's merge this as it is.

Oh. There are conflicts. @jkaluza can you just fix the conflicts and then merge it?

I think we should use that google doc I wrote instead I think. It contains more info and its also more up to date.

Let's drop this then. Thanks.

Pull-Request has been closed by gnaponie

Metadata