PR#434: py2 to py3, handle byte strings -

Signed-off-by: Giulia Naponiello gnaponie@redhat.com

But tar_data should already be bytes object in Python 3. So this should fail (AttributeError), no?

It seems like no... I tried with this:
https://paste.fedoraproject.org/paste/NPhZQ5Q2fbOJYm2aAnz8Sg

We should add probably a unit test for it... But we can only mock the file, so maybe it wouldn't make a lot of sense.

Oh, it looks like the output is str because of the universal_newlines=True option passed to Popen.

Pull-Request has been merged by gnaponie

Oct 1, 2019

Assignee

None

Tags

No Tags