freshmaker

#440 Migrate to Rover groups and add the new role of "manual_rebuilder"
Merged by gnaponie. Opened by mprahl.
mprahl/freshmaker acls  into  master

Download 440.patch

I recommending reviewing this PR by reviewing each commit to get a sense for each logical change.

Could you please check the CI? It is failing - I'm afraid it's because of f-string, which I love :(

1 new commit added

  • Use Python 3.6 to run the unit tests with tox

@gnaponie thanks for the heads up! It's passing now.

Can you add PERMISSIONS dict here with some example and documentation what are the possible roles, so we don't have to dig that from the code when deploying?

2 new commits added

  • Document the permissions configuration
  • Fix the Freshmaker description in the documentation

Can you add PERMISSIONS dict here with some example and documentation what are the possible roles, so we don't have to dig that from the code when deploying?

@jkaluza thanks. I documented this in a separate commit.

13 new commits added

  • Document the permissions configuration
  • Fix the Freshmaker description in the documentation
  • Use Python 3.6 to run the unit tests with tox
  • Add the "manual_rebuilder" role to allow non-admins to request manual rebuilds
  • Prevent tests that test authentication from affecting tests after it
  • Use singular role names instead of plural
  • Support multiple roles to access a particular API endpoint
  • Use a permissions dictionary where each key is a role instead of separate configurations per role
  • Migrate to using Rover groups for LDAP group membership verification
  • Simplify the recommended command to run the tests
  • Don't recommend using sudo when installing Freshmaker in the virtualenv
  • Stop supporting nosetest
  • Remove the unused allowed_clients role

I've checked the commit and the changes look fine.
Even though they are separated commit, it's still a big change, so I hope I didn't miss anything :D
But it looks good.

confident +1.

Commit 8603c8dd fixes this pull-request

Pull-Request has been merged by gnaponie

Pull-Request has been merged by gnaponie
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.