freshmaker

#441 Allow image rebuild for modules too
Merged by gnaponie. Opened by gnaponie.
gnaponie/freshmaker FACTORY-5323  into  master

Download 441.patch

...and not only for RPMs.

JIRA: FACTORY-5323

Signed-off-by: Giulia Naponiello gnaponie@redhat.com

@lucarval @jkaluza @mprahl PTAL

Really?! That's it?

+1

Optional: You could use sets to make it more concise:

if not {'rpm', 'module'} & set(event.advisory.content_types):

:thumbsup:

Seems missing a test case, that is content_types does not have both rpm and module.

:thumbsup:

@cqi I believe test_cannot_handle_manual_rebuild_for_non_rpm_and_module should cover that case. I'll make a small enhance to cover also the empty content_type.
Edited by gnaponie

rebased onto 2b8017e522170da59b3608a6c305f25c7f8300d1

I've added Matt's and Chenxiong's suggestions. Can anyone of you check once again?

:thumbsup:

Commit 170acd40 fixes this pull-request

Pull-Request has been merged by gnaponie

Pull-Request has been merged by gnaponie
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.