freshmaker

#450 Refactor find_images_with_included_srpms to not return duplicate images
Merged by gnaponie. Opened by mprahl.
mprahl/freshmaker handle-duplicates-earlier  into  master

Download 450.patch

This can be caused by images having multiple architectures or being in multiple target repositories.

This should reduce some of the processing required.

rebased onto c7c5369a31264f14e7b0d560722125580cf2a167

rebased onto 8a10577032bd8008eca6bce4565d3b5ffa5b9282

+1

Actually, I'm only thinking if there should be some test for that or not. I will let that decision for @gnaponie.

@jkaluza I can write a test.

rebased onto 2eb2a7f18c9b40d2b62384b39078b31c42997dc0

@jkaluza thanks for the review. I added on to an existing test. Let me know if this covers it.

@gnaponie could you please review?

Maybe I'm missing something.. but why was this underlined and now it is in the else branch?

It looks good +1

@gnaponie because get_images_by_nvrs could potentially return duplicates. Only find_images_with_included_srpms was refactored which only gets executed when leaf_container_images is not set.

@gnaponie is this good to merge?

yes! +1

Commit 124c7ec7 fixes this pull-request

Pull-Request has been merged by gnaponie

Pull-Request has been merged by gnaponie
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.