#453 Allow inheriting the advisory ID from the dependent Freshmaker event
Merged by gnaponie. Opened by mprahl.
mprahl/freshmaker errata-id  into  master

Download 453.patch

This addresses FACTORY-5508.

This also sanitizes the input on the POST API endpoint.

oh :) I hate this formatting! But that's only my thing :)

mmm I'm uncertain. Does this handle the chance that the user will pass a string "false" or "False"? We should probably accept it and convert it to bool.

Why changing these?

rebased onto e9cafb37bac5bd470b71c16bd8b87e44030691c3

oh :) I hate this formatting! But that's only my thing :)

I think this is readable and it's what the auto-formatting tool black would do, but I can change it if there's a style guide.

Why changing these?

It's confusing, but I explain it in the the commit message of the first commit in the PR.

Why changing these?

It's confusing, but I explain it in the the commit message of the first commit in the PR.

mmm I'm uncertain. Does this handle the chance that the user will pass a string "false" or "False"? We should probably accept it and convert it to bool.

I don't see the benefit of that since it's JSON, which has a boolean type for this purpose. If you feel strongly about it, I can change it. Please let me know either way.

I don't see the benefit of that since it's JSON, which has a boolean type for this purpose. If you feel strongly about it, I can change it. Please let me know either way.

I just wasn't sure about it. But it's Json, yeah, it should be handled. Let's keep it.
I'd say this looks good. +1

Pull-Request has been merged by gnaponie

Metadata