freshmaker

#480 Ensure file descriptors are closed in get_distgit_files
Merged by gnaponie. Opened by cqi.
cqi/freshmaker ensure-close-fd  into  master

Download 480.patch
no initial comment

Not sure if it's a good idea to refactor get_distgit_files, personally I'd prefer to call just one API instead of both get_distgit_files and get_distgit_url everytime.
Other changes looks good to me.

@qwan

The commit includes why doing it.

    Funtion get_distgit_files is responsible for fetching files from a
    remote repository. Therefor, it requres a repository URL as an argument
    rather than accepting relative argumnets and redirecting to
    get_distgit_url to construct the URL by itself. This change is also
    easier for testing get_distgit_files.

+1.

+1
I don't have a strong preference about that. There are some cards to change that a bit: FACTORY-5860 and FACTORY-5861. But we can merge this and come back to those in the future.

@cqi there are conflicts. Can you rebase on master?

rebased onto 9f4412098f44e341cd6734b83ba23f10576d524e

@gnaponie Done

Awesome, thank you.

Pull-Request has been merged by gnaponie
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.