PR#501: Aggregate multi-arch info in ContainerImage -

freshmaker

#501 Aggregate multi-arch info in ContainerImage

Merged Mar 10, 2020 by lucarval. Opened Mar 10, 2020 by lucarval.

lucarval/freshmaker multi-arch-unpublished into master

lucarval commented Mar 10, 2020

Signed-off-by: Luiz Carvalho lucarval@redhat.com

lucarval commented Mar 10, 2020

Hmm... architectures will contain the arches as defined in Lightblue. It will use amd64 instead of x86_64. ODCS doesn't know what amd64 is. I think I'll go ahead and drop this attribute from the ContainerImage object and use the existing arches which is populated from Brew build data, I think.

rebased onto adbca394b17135814e540935680797cfbe7bc6f9

Mar 10, 2020

lucarval commented Mar 10, 2020

Hmm... architectures will contain the arches as defined in Lightblue. It will use amd64 instead of x86_64. ODCS doesn't know what amd64 is. I think I'll go ahead and drop this attribute from the ContainerImage object and use the existing arches which is populated from Brew build data, I think.

Done.

gnaponie commented Mar 10, 2020

optional: just rpm_manifest[0].get.... and remove the previous line

gnaponie commented Mar 10, 2020

optional: a description of params in input and returned value if there is one is also useful

gnaponie commented Mar 10, 2020

it looks good \o/ +1

rebased onto 397a6de033d42ffc9b0abe4da47c5af3447c4baf

Mar 10, 2020

lucarval commented Mar 10, 2020

Addressed the optional comments, and added unit tests to cover new code.

Pull-Request has been merged by lucarval