#505 Add the script to test new freshmaker deployment
Merged by mulaieva. Opened by mulaieva.
mulaieva/freshmaker errata_id_script  into  master

Download 505.patch

Find out the lstest successful event and get it the errata_id.
At the moment, when we release a new freshmaker version, we start a
dry-run build to manually check that the deployment was successful
curl --negotiate -u : -k -X POST -d '{"errata_id": 46932, "dry_run": true}'
https://freshmaker.dev.engineering.redhat.com/api/1/builds/ -l -v
But if the errata_id is old, it can happen that the build won't be
successful. This script is for this reason, it extract the errata_id
and then run that curl command. This way, we don't need to update the
documentation every time this happens.
JIRA: https://projects.engineering.redhat.com/browse/FACTORY-5408

Could you add the reference to the jira card in the commit message?

s/erraita_id/errata_id/g

It would be nice to have prod by default, and maybe add a parameter to this script (maybe with argparse) that will allow to specify if you want to run this in dev.
For example I could run:
python3 dev_scripts/last_errata_id.py --dev true

Using argparse we also automatically have a nice --help parameter.

Instead of last_errata_id.py, since this is a script for submitting a dry run build on the latest errata, I'd maybe call it build_last_errata_on_dry_run_mode.py
or something more explicit... I'm bad bad bad at names.

rebased onto c6c1837f232c8e9f3c6251e05cec2c642daf1221

@gnaponie , all notes are fixed

Can you add some comment to explain why this was created? Like:
This script can be useful to try a build in dry_run mode after a complete deployment, to manually test if the deployment was successful. It automatically selects, from the latest successful build, the errata_id and it submits a build in dry_run mode.

The name of the script was updated.

rebased onto ca2121a0426f16cd9dd047fd2899451d21a26d94

@gnaponie ,review now, please

Awesome! Looks good, thank you, Mariana +1
Feel free to remove the WIP and merge it.

Commit d12fa7ea fixes this pull-request

Pull-Request has been merged by mulaieva

Pull-Request has been merged by mulaieva

Metadata