PR#509: Refactor images filter methods - - Pagure.io

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

freshmaker

#509 Refactor images filter methods

Closed Jun 15, 2020 by mprahl. Opened Mar 26, 2020 by cqi.

cqi/freshmaker refactor-higher-srpm-nvr-filter into master

Download 509.patch

cqi commented Mar 26, 2020

This change refactors two filter methods
filter_out_images_with_higher_srpm_nvr and
filter_out_modularity_mismatch.

Signed-off-by: Chenxiong Qi cqi@redhat.com

apaplaus commented Apr 7, 2020

+1

jkaluza commented Apr 15, 2020

+1.

gnaponie commented Apr 16, 2020

looks good. @cqi feel free to merge this PR

gnaponie commented Apr 22, 2020

@cqi can you please resolve the conflicts so we can merge this?

gnaponie commented May 5, 2020

@cqi ping?

rebased onto 3db5202aadcf29363ec1a47d6bc4faf4f642510a

Jun 2, 2020

cqi commented Jun 2, 2020

@gnaponie PTAL

qwan commented Jun 3, 2020

Could you also update these comments?

gnaponie commented Jun 11, 2020

Besides qwan's comment, it looks good.

mprahl commented Jun 15, 2020

Freshmaker has been migrated to GitHub. Please reopen your PR on GitHub.

Pull-Request has been closed by mprahl

Jun 15, 2020

Metadata

Assignee

None

Tags

No Tags

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.