#51 Allow to specify namespace to BaseHandler.build_container
Merged by jkaluza. Opened by cqi.
cqi/freshmaker allow-specify-namespace  into  master

Download 51.patch

This patch also correct docstring of build_container method.

Signed-off-by: Chenxiong Qi cqi@redhat.com

Looks good to me. In which cases that container can be built under other namespaces rather than 'container'?

@qwan: I think this is needed for internal RH deployment, where the containers are in different namespace.

Tests have not been started because of jenkins issues, new test run (passed) here: https://jenkins.fedorainfracloud.org/job/freshmaker/195/

Pull-Request has been merged by jkaluza

@qwan

@jkaluza 's comment is right. So far, there is no container namespace in internal dist-git. AFAIK as I look at a few docker image repositories, they are now in rpms/.

Metadata