freshmaker

#512 Make resolve_commit not set published property
Merged by cqi. Opened by cqi.
cqi/freshmaker remove-side-effect  into  master

Download 512.patch

A ContainerImage published property is resolved and set by
resolve_published. Therefore, if resolve_commit sets the published
property, there will be a side-effect when resolve_commit is called
again against an already resolved image, that is published property is
reset to None.

Whatever a ContainerImage is published or not, resolve_published will
always set the property. So, just simply remove published from
return value of _get_default_additional_data().

Resolves: FACTORY-6028

Signed-off-by: Chenxiong Qi cqi@redhat.com

:thumbsup: I like this approach because if a piece of the code is accessing the published property before resolve_published has been called, for whatever reason, then an exception will be raised, instead of silently assuming the image in not published.

+1

Commit 4c7e4d8c fixes this pull-request

Pull-Request has been merged by cqi

Pull-Request has been merged by cqi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.